Crash caused by ACTION_TYPE_SPRING type check


Since bugs I report on the worklist don’t seem to get noticed, I thought it would be most constructive to post this here: Latest GIT master introduces a crash, which occurs a few seconds after Hifi has started and you are in the world. The error of the crash is:

interface: /foo/bar/HighFidelity/libraries/physics/src/ObjectActionSpring.cpp:192: virtual void ObjectActionSpring::deserialize(QByteArray): Assertion `type == ACTION_TYPE_SPRING' failed.

As advised on IRC, I tried changing assert(type == ACTION_TYPE_SPRING) into assert(type == getType()) and that fixed the problem. Hopefully this is an useful indicator about the issue and can help.


This has been fixed in GIT today. Thank you.